apps/server/src/providers/cursor-provider.ts (1)

988-989: Consider restricting temp file permissions to owner-only.

The prompt file is created with default permissions (typically 644), making it world-readable. Since prompts may contain sensitive instructions or context, consider setting explicit 0o600 permissions:

🔒 Proposed fix

       fs.mkdirSync(automakerDir, { recursive: true });
-      fs.writeFileSync(promptFilePath, promptText, 'utf8');
+      fs.writeFileSync(promptFilePath, promptText, { encoding: 'utf8', mode: 0o600 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/server/src/providers/cursor-provider.ts` around lines 988 - 989, The
prompt file is created with default world-readable permissions; update the
creation to restrict access to the owner only by setting explicit modes: create
the directory automakerDir with owner-only permissions (e.g., 0o700) via
fs.mkdirSync(..., { recursive: true, mode: 0o700 }) and write the prompt file
promptFilePath with owner-only file permissions (0o600) by using
fs.writeFileSync(promptFilePath, promptText, { encoding: 'utf8', mode: 0o600 })
or, if you prefer, call fs.chmodSync(promptFilePath, 0o600) immediately after
fs.writeFileSync; ensure you reference automakerDir, promptFilePath, and
promptText when making the changes.

apps/server/src/providers/cursor-provider.ts (1)

544-553: ⚠️ Potential issue | 🟠 Major

NPX temp-file mode still wraps bash -c through npx.

This branch builds npx … bash -c …, so bash and -c become arguments to the Cursor package instead of running the shell command. Long prompts will still fail for detectedStrategy === 'npx'.

Suggested fix

     if (this.detectedStrategy === 'npx') {
-      const allArgs = [...this.npxArgs, 'bash', '-c', fullCommand];
       return {
-        command: 'npx',
-        args: allArgs,
+        command: 'bash',
+        args: ['-c', fullCommand],
         cwd,
         env: filteredEnv,
         abortController: options.abortController,
         timeout,
       };
     }

#!/bin/bash
rg -n -C3 "detectedStrategy === 'npx'|command: 'npx'|bash', '-c'|fullCommand" apps/server/src/providers/cursor-provider.ts

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/server/src/providers/cursor-provider.ts` around lines 544 - 553, The npx
branch currently constructs args [...this.npxArgs, 'bash', '-c', fullCommand]
which makes 'bash' be treated as an npx package argument instead of a
subprocess; change the returned args so bash is executed (e.g., insert the npx
argument separator '--' before 'bash' so args become [...this.npxArgs, '--',
'bash', '-c', fullCommand]) or alternatively skip npx and set command to 'bash'
with args ['-c', fullCommand]; update the code paths referencing
detectedStrategy, npxArgs, fullCommand and the object returning command: 'npx'
accordingly so long prompts are passed to the shell rather than to npx as
package names.

apps/server/src/providers/cursor-provider.ts (3)

544-553: ⚠️ Potential issue | 🟠 Major

NPX temp-file execution path is still malformed.

This path invokes npx with bash -c as package args, so the shell command is not executed as intended for long prompts.

🐛 Proposed fix

-    if (this.detectedStrategy === 'npx') {
-      const allArgs = [...this.npxArgs, 'bash', '-c', fullCommand];
-      return {
-        command: 'npx',
-        args: allArgs,
-        cwd,
-        env: filteredEnv,
-        abortController: options.abortController,
-        timeout,
-      };
-    }
+    if (this.detectedStrategy === 'npx') {
+      const escapedNpxArgs = this.npxArgs.map((a) => this.escapeForBashSingleQuoted(a)).join(' ');
+      const npxCommand = `npx ${escapedNpxArgs} ${escapedArgs} "$(cat ${escapedPath})"`;
+      return {
+        command: 'bash',
+        args: ['-c', npxCommand],
+        cwd,
+        env: filteredEnv,
+        abortController: options.abortController,
+        timeout,
+      };
+    }

#!/bin/bash
# Verify NPX branch construction in prompt-file mode
rg -n -A20 -B4 "if \\(this\\.detectedStrategy === 'npx'\\)" apps/server/src/providers/cursor-provider.ts

Expected: NPX branch should execute via a shell command (command: 'bash'), not pass bash -c through npx args.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/server/src/providers/cursor-provider.ts` around lines 544 - 553, The NPX
branch currently returns command 'npx' with npxArgs plus 'bash' and '-c' in the
args, which causes the shell to be passed as an NPX package instead of executing
the shell command; update the block where this.detectedStrategy === 'npx' (and
where npxArgs, fullCommand are used) to return command: 'bash' and args: ['-c',
fullCommand] (preserve cwd, env: filteredEnv, abortController:
options.abortController, and timeout) so the shell executes the
temporary-file/fullCommand directly rather than being invoked through npx.

---

556-563: ⚠️ Potential issue | 🟠 Major

Long-prompt fallback should not default to bash for native Windows strategies.

For cmd/direct detections on Windows, this branch can fail with bash not found. Add an explicit strategy branch (or a clear fail-fast with guidance) before the bash fallback.

💡 Minimal fail-fast safeguard

+    if (
+      process.platform === 'win32' &&
+      !this.useWsl &&
+      (this.detectedStrategy === 'cmd' || this.detectedStrategy === 'direct')
+    ) {
+      throw new Error(
+        'Long prompt execution on native Windows requires WSL. Install WSL or reduce prompt length.'
+      );
+    }
+
     return {
       command: 'bash',
       args: ['-c', fullCommand],
       cwd,
       env: filteredEnv,

#!/bin/bash
# Verify Windows strategy outputs and prompt-file fallback branches
rg -n "strategy: 'cmd'|strategy: 'direct'" apps/server/src/providers/cursor-provider.ts
rg -n -A35 -B6 "buildSubprocessOptionsWithPromptFile\\(" apps/server/src/providers/cursor-provider.ts

Expected: prompt-file mode should explicitly handle native Windows strategies, not only WSL/NPX + bash fallback.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/server/src/providers/cursor-provider.ts` around lines 556 - 563, The
long-prompt fallback currently returns a bash-based subprocess spec which will
fail on native Windows when strategy is 'cmd' or 'direct'; update
buildSubprocessOptionsWithPromptFile (or the function that returns the object
with command: 'bash', args: ['-c', fullCommand]) to first detect Windows-native
strategies ('cmd' and 'direct') and either: (a) produce a Windows-compatible
spec (use 'cmd.exe' with '/C' or the direct command invocation) for those
strategies, or (b) immediately fail-fast with a clear error message instructing
the user to enable WSL/NPX or switch strategy, so the code does not silently
assume bash on Windows. Ensure you reference the same return object
(command/args/env/abortController/timeout) when implementing the new branches.

---

983-1000: ⚠️ Potential issue | 🟠 Major

Temp prompt cleanup is not guaranteed if setup throws before the try.

promptFilePath is created and written before entering the try. Any failure during subsequent setup can leave prompt data on disk.

♻️ Proposed restructuring

-    if (useTempFile) {
-      // create/write file...
-      ...
-    } else {
-      ...
-    }
-
-    ...
-    try {
+    try {
+      if (useTempFile) {
+        // create/write file...
+        ...
+      } else {
+        ...
+      }
+
+      ...
       for await (const rawEvent of spawnJSONLProcess(subprocessOptions)) {
         ...
       }

Also applies to: 1026-1128

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/server/src/providers/cursor-provider.ts` around lines 983 - 1000, The
temp prompt file is created before the subsequent setup and thus can be leaked
if an exception occurs; move the creation and write of promptFilePath into the
same try block that later performs setup (or ensure a finally block always
deletes promptFilePath), so that any throw after calling buildCliArgs or
buildSubprocessOptionsWithPromptFile still triggers cleanup; specifically update
the block that uses getAutomakerDir, randomBytes and fs.writeFileSync to either
(A) create/write the file inside the try that wraps calls to this.buildCliArgs
and this.buildSubprocessOptionsWithPromptFile, or (B) keep creation where it is
but add a finally that checks promptFilePath and unlinks it, and apply the same
change to the duplicate region later (around the code using buildCliArgs and
buildSubprocessOptionsWithPromptFile).

apps/server/src/providers/cursor-provider.ts (3)

986-1007: ⚠️ Potential issue | 🟠 Major

Start the try/finally before creating the temp prompt file.

If Lines 989-1006 or Lines 1018-1019 throw, the file created at Line 991 survives because the finally block only starts at Line 1123. Wrap the temp-file creation and the rest of the pre-spawn setup in the same try/finally so cleanup is guaranteed.

Also applies to: 1017-1021, 1123-1131

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/server/src/providers/cursor-provider.ts` around lines 986 - 1007, The
temp prompt file creation and all pre-spawn setup must be inside the same
try/finally so the prompt file is always cleaned up; move the start of the try
block to begin before the temp-file creation (the block that uses useTempFile,
getAutomakerDir, randomBytes, promptFilePath, fs.writeFileSync) and keep the
existing finally that removes promptFilePath, ensuring buildCliArgs,
buildSubprocessOptionsWithPromptFile (and the else-path calling
buildCliArgs/buildSubprocessOptions) are executed inside that try; update the
scope so any exception thrown during creation or setup still triggers the
finally to delete promptFilePath.

---

989-993: ⚠️ Potential issue | 🟠 Major

Create the temp prompt file with restrictive permissions.

fs.writeFileSync(promptFilePath, promptText, 'utf8') inherits the process umask, so these files are commonly created as 0644 on Unix-like hosts. This file contains the full merged prompt and should be written as 0600 from the start.

🔐 Proposed fix

-      fs.writeFileSync(promptFilePath, promptText, 'utf8');
+      fs.writeFileSync(promptFilePath, promptText, { encoding: 'utf8', mode: 0o600 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/server/src/providers/cursor-provider.ts` around lines 989 - 993, The
temp prompt file is being created with fs.writeFileSync(promptFilePath,
promptText, 'utf8') which inherits the process umask and can be world-readable;
change the write to explicitly set restrictive permissions by calling
fs.writeFileSync with an options object that includes encoding 'utf8' and mode
0o600 (e.g., replace the current fs.writeFileSync call for promptFilePath with
one that passes { encoding: 'utf8', mode: 0o600 }); locate the code around
getAutomakerDir, promptId and promptFilePath to update that write and ensure the
file is created with 0600 from the start.

---

540-566: ⚠️ Potential issue | 🟠 Major

Fail fast for native Windows long prompts.

cmd/direct installs still fall through to bash -c ... "$(cat ...)". That assumes Bash is present on Windows, and even if it is, the expanded prompt still has to fit in the final cursor-agent.exe command line, so this path does not reliably solve the Win32 limit. Please branch native Windows here and return a clear “use WSL / shorten the prompt” error instead of the Bash fallback.

🐛 Suggested direction

+    if (
+      process.platform === 'win32' &&
+      (this.detectedStrategy === 'cmd' || this.detectedStrategy === 'direct')
+    ) {
+      throw new Error(
+        'Long prompts require Cursor via WSL because native Windows installs cannot bypass the Win32 command-line limit.'
+      );
+    }
+
     return {
       command: 'bash',
       args: ['-c', fullCommand],
       cwd,

apps/server/src/providers/cursor-provider.ts (1)

432-567: Add focused coverage for the long-prompt branches.

The current unit tests only exercise --resume, so they will not catch regressions in omitPrompt, temp-file spawning, or the WSL/npx/native-Windows branching introduced here. A small table-driven test around buildCliArgs(..., { omitPrompt: true }) and buildSubprocessOptionsWithPromptFile() would lock this behavior down.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/server/src/providers/cursor-provider.ts` around lines 432 - 567, Add
unit tests that exercise buildCliArgs(..., { omitPrompt: true }) and
buildSubprocessOptionsWithPromptFile(...) in a table-driven way: include cases
for cliPath containing 'cursor' vs 'cursor-agent' (to verify 'agent'
subcommand), readOnly true/false (to assert '--mode ask --trust' vs '--force'),
model !== 'auto', sdkSessionId present, and extras.omitPrompt true to ensure the
prompt is omitted; separately test buildSubprocessOptionsWithPromptFile with
useWsl + wslCliPath (assert command is 'wsl.exe' and args include the WSL path
and bash -c with "$(cat ...)"), with detectedStrategy === 'npx' (assert command
'bash' and args '-c' run full npx command with escaped npxArgs), and the native
case (command 'bash' with fullCommand), and in all cases assert that paths are
escaped via escapeForBashSingleQuoted and env/timeout/abortController/cwd are
preserved.